[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876481#comment-14876481
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39903426
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManager.java
---
@@ -19,37 +19,66 @@
package com.cloud.network.manager;
-import java.util.List;
-
-import org.apache.cloudstack.framework.config.ConfigKey;
-import org.apache.cloudstack.framework.config.ConfigKey.Scope;
-
import com.cloud.api.commands.AddNuageVspDeviceCmd;
import com.cloud.api.commands.DeleteNuageVspDeviceCmd;
import com.cloud.api.commands.ListNuageVspDevicesCmd;
+import com.cloud.api.commands.UpdateNuageVspDeviceCmd;
import com.cloud.api.response.NuageVspDeviceResponse;
+import com.cloud.network.Network;
import com.cloud.network.NuageVspDeviceVO;
import com.cloud.utils.component.PluggableService;
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.ConfigKey.Scope;
+
+import java.util.List;
public interface NuageVspManager extends PluggableService {
- static final String NUAGE_VPC_OFFERING_NAME = "Default VPC offering
with NuageVsp";
+ public static final String
nuageVspSharedNetworkOfferingWithSGServiceName =
"DefaultNuageVspSharedNetworkOfferingWithSGService";
- static final String NUAGE_VPC_OFFERING_DISPLAY_TEXT = "Default VPC
offering with NuageVsp";
+ public static final String nuageVPCOfferingName = "Nuage VSP VPC
Offering";
- static final ConfigKey<Integer> NuageVspSyncInterval = new
ConfigKey<Integer>(Integer.class, "nuagevsp.sync.interval", "Advanced", "480",
- "The interval (in minutes) to wait before running the next
synchronization worker to synchronize the information between CloudStack and
NuageVsp", false, Scope.Global,
- 1);
+ public static final String nuageVPCOfferingDisplayText = "Nuage VSP
VPC Offering";
- static final ConfigKey<Integer> NuageVspSyncWorkers = new
ConfigKey<Integer>(Integer.class, "nuagevsp.sync.workers", "Advanced", "1",
- "Number of workers to synchronize the information between
CloudStack and NuageVsp", false, Scope.Global, 1);
+ static final ConfigKey<Boolean> NuageVspConfigDns = new
ConfigKey<Boolean>(Boolean.class, "nuagevsp.configure.dns", "Advanced", "true",
+ "Defines if NuageVsp plugin needs to configure DNS setting for
a VM or not. True will configure the DNS and false will not configure the DNS
settings", true,
+ Scope.Global, null);
- NuageVspDeviceVO addNuageVspDevice(AddNuageVspDeviceCmd cmd);
+ static final ConfigKey<Boolean> NuageVspDnsExternal = new
ConfigKey<Boolean>(
+ Boolean.class,
+ "nuagevsp.dns.external",
+ "Advanced",
+ "true",
+ "Defines if NuageVsp plugin needs to configure either internal
or external DNS server configured during Zone provisioning. "
+ + "Value true uses the external DNS and value false
uses the internal DNS to configure in the VM. But, this flag depends on "
+ + "nuagevsp.configure.dns. Only if
nuagevsp.configure.dns is set to true, DNS server will be configured in the VM.
"
+ + "If nuagevsp.configure.dns is false, DNS server will
not be configured in the VM. Default value for this flag is true",
+ true, Scope.Global, null);
- NuageVspDeviceResponse createNuageVspDeviceResponse(NuageVspDeviceVO
nuageVspDeviceVO);
+ static final ConfigKey<String> NuageVspConfigGateway = new
ConfigKey<String>(String.class, "nuagevsp.configure.gateway.systemid",
"Advanced", "",
+ "Defines the systemID of the gateway configured in VSP", true,
Scope.Global, null);
+
+ static final ConfigKey<String> NuageVspSharedNetworkDomainTemplateName
= new ConfigKey<String>(String.class, "nuagevsp.sharedntwk.domaintemplate.name",
+ "Advanced", "", "Defines if NuageVsp plugin needs to use pre
created Domain Template configured in VSP for shared networks", true,
Scope.Global, null);
+
+ static final ConfigKey<String> NuageVspVpcDomainTemplateName = new
ConfigKey<String>(String.class, "nuagevsp.vpc.domaintemplate.name",
+ "Advanced", "", "Defines if NuageVsp plugin needs to use pre
created Domain Template configured in VSP for VPCs", true, Scope.Global, null);
+
+ static final ConfigKey<String>
NuageVspIsolatedNetworkDomainTemplateName = new ConfigKey<String>(String.class,
"nuagevsp.isolatedntwk.domaintemplate.name",
+ "Advanced", "", "Defines if NuageVsp plugin needs to use pre
created Domain Template configured in VSP for isolated networks", true,
Scope.Global, null);
+
--- End diff --
Why aren't these constants declared ``private`` or ``public``?
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
