[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876579#comment-14876579
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/801#discussion_r39907061
  
    --- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
 ---
    @@ -441,6 +456,44 @@ private Answer executeRequest(SyncVspCommand cmd) {
             }
         }
     
    +    private Answer executeRequest(SyncNuageVspCmsIdCommand cmd) {
    +        try {
    +            isNuageVspManagerLoaded();
    +            if (cmd.getSyncType() == SyncType.AUDIT || cmd.getSyncType() 
== SyncType.AUDIT_ONLY) {
    +                Pair<Boolean, String> answer = 
_nuageVspManagerClient.auditNuageVspCmsId(cmd.getNuageVspCmsId(), 
cmd.getSyncType() == SyncType.AUDIT_ONLY);
    +                return new SyncNuageVspCmsIdAnswer(answer.getLeft(), 
answer.getRight(), cmd.getSyncType());
    +            } else if (cmd.getSyncType() == SyncType.REGISTER) {
    +                String registeredNuageVspCmsId = 
_nuageVspManagerClient.registerNuageVspCmsId();
    +                return new 
SyncNuageVspCmsIdAnswer(StringUtils.isNotBlank(registeredNuageVspCmsId), 
registeredNuageVspCmsId, cmd.getSyncType());
    +            } else {
    +                boolean success = 
_nuageVspManagerClient.unregisterNuageVspCmsId(cmd.getNuageVspCmsId());
    +                return new SyncNuageVspCmsIdAnswer(success, 
cmd.getNuageVspCmsId(), cmd.getSyncType());
    +            }
    +        } catch (Exception e) {
    --- End diff --
    
    Log the exception to error.


> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-8832
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0
>            Reporter: Nick Livens
>            Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for 
> this release



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to