[
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936526#comment-14936526
]
ASF GitHub Bot commented on CLOUDSTACK-8893:
--------------------------------------------
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/871#issuecomment-144322464
@pavanb018 it always helps other folks reviewing to know what you did. For
example.
Did you just check the Travis green light ? Did you just check the code
through github ? Did you pull the patch, apply and compile ? Did you do the
build then run the tests. It may sound obvious to you what you did by giving
the copy paste form a test, but writing a small friendly sentence for the next
reviewer will go a long way to help us merge those fixes as a group.
thanks
> test_vm_snapshots.py requires modification since we support volume snapshot
> on a vm with vm snapshot
> ----------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
> Issue Type: Test
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Automation
> Affects Versions: 4.6.0
> Reporter: Sanjeev N
> Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with
> vm snapshots .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
