[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951836#comment-14951836
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8912:
--------------------------------------------

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/890#discussion_r41697298
  
    --- Diff: 
api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java
 ---
    @@ -44,10 +44,10 @@
         /////////////////////////////////////////////////////
     
         @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType 
= GuestOsMappingResponse.class, required = false, description = "list mapping 
by its UUID")
    -    private Long id;
    +    private String id;
    --- End diff --
    
    This can cause issues here, during Cmd object creation arguments values of 
keys ID and OS_TYPE_ID will be converted to a Long as the parameter type 
defined here is CommandType.UUID. 
    
    This is where this happens: 
https://github.com/apache/cloudstack/blob/master/server/src/com/cloud/api/dispatch/ParamProcessWorker.java#L318
    
    If you really want Strings here, please change the @Parameter annotation 
type to CommandType.STRING etc.


> listGuestOsMapping doesn't list by id or ostypeid.
> --------------------------------------------------
>
>                 Key: CLOUDSTACK-8912
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8912
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.5.2, 4.6.0
>            Reporter: Boris Schrijver
>             Fix For: 4.5.3, 4.6.0
>
>
> The listGuestOsMapping doesn't list by id (uuid) or ostypeid (uuid).
> The values are both Long instead of String. And the searchCriteria is 
> searching for id instead of uuid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to