[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953399#comment-14953399
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41778534
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -368,18 +492,15 @@ public boolean applyStaticNats(Network config, List<?
extends StaticNat> rules)
sourceNatDetails.add(sourceNatDetail);
}
try {
- try {
- HostVO nuageVspHost =
getNuageVspHost(config.getPhysicalNetworkId());
- ApplyStaticNatVspCommand cmd = new
ApplyStaticNatVspCommand(networkDomain.getUuid(), vpcOrSubnetUuid, isL3Network,
sourceNatDetails);
- ApplyStaticNatVspAnswer answer =
(ApplyStaticNatVspAnswer)_agentMgr.easySend(nuageVspHost.getId(), cmd);
- if (answer == null || !answer.getResult()) {
- s_logger.error("ApplyStaticNatNuageVspCommand for
network " + config.getUuid() + " failed");
- if ((null != answer) && (null != answer.getDetails()))
{
- throw new
ResourceUnavailableException(answer.getDetails(), Network.class,
config.getId());
- }
+ HostVO nuageVspHost =
getNuageVspHost(config.getPhysicalNetworkId());
+ ApplyStaticNatVspCommand.Builder cmdBuilder = new
ApplyStaticNatVspCommand.Builder().networkDomainUuid(networkDomain.getUuid())
+
.networkUuid(config.getUuid()).vpcOrSubnetUuid(vpcOrSubnetUuid).isL3Network(isL3Network).isVpc(vpcId
!= null).staticNatDetails(sourceNatDetails);
+ ApplyStaticNatVspAnswer answer =
(ApplyStaticNatVspAnswer)_agentMgr.easySend(nuageVspHost.getId(),
cmdBuilder.build());
+ if (answer == null || !answer.getResult()) {
+ s_logger.error("ApplyStaticNatNuageVspCommand for network
" + config.getUuid() + " failed");
+ if ((null != answer) && (null != answer.getDetails())) {
+ throw new
ResourceUnavailableException(answer.getDetails(), Network.class,
config.getId());
}
- } catch (Exception e) {
- s_logger.warn("Failed to apply static Nat in Vsp " +
e.getMessage());
}
} catch (Exception e) {
--- End diff --
Why are all checked and unchecked exceptions being caught here? Why not
catch the subset of expected checked exceptions?
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
