[
https://issues.apache.org/jira/browse/CLOUDSTACK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956412#comment-14956412
]
ASF GitHub Bot commented on CLOUDSTACK-7984:
--------------------------------------------
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/926#discussion_r41961770
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -310,8 +326,17 @@ private void init(Map<String, String> configs) {
_executor.scheduleAtFixedRate(new VmDiskStatsTask(),
vmDiskStatsInterval, vmDiskStatsInterval, TimeUnit.SECONDS);
}
+ if (vmNetworkStatsInterval > 0) {
+ if (vmNetworkStatsInterval < 300)
+ vmNetworkStatsInterval = 300;
+ _executor.scheduleAtFixedRate(new VmNetworkStatsTask(),
vmNetworkStatsInterval, vmNetworkStatsInterval, TimeUnit.SECONDS);
+ } else {
+ s_logger.debug("vm.network.stats.interval - " +
vmNetworkStatsInterval + " so not scheduling the vm network stats thread");
--- End diff --
Maybe explain here that a negative value is not allowed?
> Collect network statistics for VMs on shared network
> ----------------------------------------------------
>
> Key: CLOUDSTACK-7984
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7984
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Environment: KVM
> Reporter: Wei Zhou
> Assignee: Wei Zhou
> Fix For: 4.6.0
>
>
> now we get the network usage from virtual router which is only applied on
> isolated network.
> We need to collect the network statistics for VM nics on shared network. The
> data can be fetched from the hypervisor.
> Similar to vm disk statistics, I will implement it for KVM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
