[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974739#comment-14974739
 ] 

ASF subversion and git services commented on CLOUDSTACK-8889:
-------------------------------------------------------------

Commit 4fe56daf4b2d7daa9318db3d5db244834bf0b305 in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4fe56da ]

Merge pull request #860 from karuturi/CLOUDSTACK-8889

CLOUDSTACK-8889: delete volume doesnt decrement primary store resource 
countPrimary Storage count for an account does not decrease when a Data Disk
is deleted belonging to the account unless the VM to which volume
belonged is destroyed

The resource counts are updated even before the disk is actually deleted
resulting in the same value.
Moved the resource counts updation to after the expunge operation as
thats when the disk is actually deleted.

Testing:
 Earlier, test_create_multiple_volumes in 
test/integration/component/test_ps_limits.py failed  with error AssertionError: 
Resource count 37 should match with the expected resource count 32

Before

Test create multiple volumes ... === TestName: 
test_create_multiple_volumes_1_root_domain_admin | Status : FAILED ===
FAIL
Test create multiple volumes ... === TestName: 
test_create_multiple_volumes_2_child_domain_admin | Status : FAILED ===
FAIL

After the Fix

Test create multiple volumes ... === TestName: 
test_create_multiple_volumes_1_root_domain_admin | Status : SUCCESS ===
ok
Test create multiple volumes ... === TestName: 
test_create_multiple_volumes_2_child_domain_admin | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 2 tests in 334.823s

OK

* pr/860:
  CLOUDSTACK-8889: delete volume doesnt decrement primary store resource count

Signed-off-by: Remi Bergsma <[email protected]>


> Primary Storage count for an account does not decrease when a Data Disk is 
> deleted belonging to the account unless the VM to which volume belonged is 
> destroyed
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8889
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8889
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.5.2, 4.6.0
>            Reporter: Rajani Karuturi
>            Assignee: Rajani Karuturi
>
> Steps to reproduce:
> 1. Create an account, deploy a VM in it
> 2. Create a data disk and attach to VM
> 3. Check the primary storage count for the account with listAccounts API
> 4. Delete the Data disk
> 5. Check the primary storage count for the account with listAccounts API - It 
> is the same as before deleting the data disk
> It should decrease when data disk is deleted.
> Now delete the VM. You can see the primary storage count is decreased by 
> (root volume size + data disk size)
> Primary Storage Limits test cases are failing due to this.
> testReport/junit/integration.component.test_ps_limits/TestVolumeLimits/test_create_multiple_volumes_1_root_domain_admin/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to