[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974892#comment-14974892
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43043089
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -395,65 +505,135 @@ public IpDeployer getIpDeployer(Network network) {
@Override
public boolean applyFWRules(Network network, List<? extends
FirewallRule> rules) throws ResourceUnavailableException {
- s_logger.debug("Handling applyFWRules for network " +
network.getName() + " with " + rules.size() + " FWRules");
- if (rules != null && rules.size() == 1 &&
rules.iterator().next().getType().equals(FirewallRuleType.System)) {
- s_logger.debug("Default ACL added by CS as system is ignored
for network " + network.getName() + " with rule " + rules);
+ if (rules == null || rules.isEmpty()) {
return true;
}
- return applyACLRules(network, rules, false);
+
+ if (rules.size() == 1 &&
rules.iterator().next().getType().equals(FirewallRuleType.System)) {
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug("Default ACL added by CS as system is
ignored for network " + network.getName() + " with rule " + rules);
+ }
+ return true;
+ }
+
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug("Handling applyFWRules for network " +
network.getName() + " with " + rules.size() + " FWRules");
+ }
+ return applyACLRules(network, rules, false,
rules.iterator().next().getTrafficType().equals(FirewallRule.TrafficType.Ingress),
false);
+ }
+
+ protected boolean applyACLRules(Network network, List<? extends
InternalIdentity> rules, boolean isNetworkAcl, Boolean isAcsIngressAcl, boolean
networkReset)
--- End diff --
It seems like it would be useful to add some ``INFO`` logging to this
method to explain successful application of rules to a Nuage device. We have a
general issue that CloudStack operators are required to run ACS with ``DEBUG``
logging to understand the operation of the management server. It is best that
we not add to that technical debt.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
