[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975073#comment-14975073
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r43053334
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -191,36 +188,26 @@ public boolean configure(String name, Map<String,
Object> params) throws Configu
return true;
}
- protected void login() throws Exception {
+ protected void login() throws ConfigurationException,
ExecutionException {
isNuageVspApiLoaded();
_nuageVspApiClient.login();
}
- protected <A extends NuageVspApiClient, B extends
NuageVspElementClient, C extends NuageVspSyncClient, D extends
NuageVspGuruClient> void loadNuageClient() throws Exception {
+ protected <A extends NuageVspApiClient, B extends
NuageVspElementClient, C extends NuageVspSyncClient, D extends
NuageVspGuruClient> void loadNuageClient() {
try {
- ClassLoader loader =
NuageVspPluginClientLoader.getClassLoader(NUAGE_PLUGIN_CLIENT_JAR_FILE);
-
- Class<?> nuageVspApiClientClass =
Class.forName(NUAGE_VSP_API_CLIENT_IMPL, true, loader);
- Class<?> nuageVspSyncClientClass =
Class.forName(NUAGE_VSP_SYNC_CLIENT_IMPL, true, loader);
- Class<?> nuageVspGuruClientClass =
Class.forName(NUAGE_VSP_GURU_CLIENT_IMPL, true, loader);
- Class<?> nuageVspElementClientClass =
Class.forName(NUAGE_VSP_ELEMENT_CLIENT_IMPL, true, loader);
-
- //Instantiate the instances
- _nuageVspApiClient =
(NuageVspApiClient)nuageVspApiClientClass.newInstance();
- _nuageVspApiClient.setNuageVspHost(_relativePath,
_cmsUserInfo, _numRetries, _retryInterval);
- _nuageVspSyncClient =
(NuageVspSyncClient)nuageVspSyncClientClass.newInstance();
- _nuageVspSyncClient.setNuageVspApiClient(_nuageVspApiClient);
- _nuageVspGuruClient =
(NuageVspGuruClient)nuageVspGuruClientClass.newInstance();
- _nuageVspGuruClient.setNuageVspApiClient(_nuageVspApiClient);
- _nuageVspElementClient =
(NuageVspElementClient)nuageVspElementClientClass.newInstance();
-
_nuageVspElementClient.setNuageVspApiClient(_nuageVspApiClient);
+ NuageVspPluginClientLoader clientLoader =
NuageVspPluginClientLoader.getClientLoader(_relativePath, _cmsUserInfo,
_numRetries, _retryInterval, _nuageVspCmsId);
+ _nuageVspApiClient = clientLoader.getNuageVspApiClient();
+ _nuageVspSyncClient = clientLoader.getNuageVspSyncClient();
+ _nuageVspGuruClient = clientLoader.getNuageVspGuruClient();
+ _nuageVspElementClient =
clientLoader.getNuageVspElementClient();
+ _nuageVspManagerClient =
clientLoader.getNuageVspManagerClient();
_isNuageVspClientLoaded = true;
- } catch (Exception e) {
+ } catch (ConfigurationException e) {
_isNuageVspClientLoaded = false;
String errorMessage = "Nuage Vsp Plugin client is not yet
installed. Please install NuageVsp plugin client to use NuageVsp plugin in
Cloudstack. ";
s_logger.warn(errorMessage + e.getMessage());
--- End diff --
Add the exception to the log statement to ensure the stack trace is added
to the log.
Also, if we are throwing an exception, why are logging to ``WARN`` and not
``ERROR``?
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
> Attachments: nuageVspMarvinLogs.tar.gz
>
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
