[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988917#comment-14988917
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9022:
--------------------------------------------

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1029#discussion_r43844404
  
    --- Diff: setup/db/db/schema-452to460.sql ---
    @@ -420,3 +420,6 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` 
(uuid,hypervisor_type, hypervis
     INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'KVM', 'default', 'CentOS 7', 246, utc_timestamp(), 0);
     
     UPDATE  `cloud`.`hypervisor_capabilities` SET  `max_data_volumes_limit` =  
'32' WHERE  `hypervisor_capabilities`.`hypervisor_type` =  'KVM';
    +
    +INSERT IGNORE INTO `cloud`.`configuration` (`category`, `instance`, 
`component`, `name`, `value`, `default_value`, `description`) VALUES 
('Advanced', 'DEFAULT', 'StorageManager', 'storage.cleanup.delay', '86400', 
'86400', 'Determines how long (in seconds) to wait before actually expunging 
destroyed volumes. The default value = the default value of 
storage.cleanup.interval.');
    --- End diff --
    
    This is not required when Configurable interface is used


> We should keep Destroyed volumes for some time
> ----------------------------------------------
>
>                 Key: CLOUDSTACK-9022
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9022
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>
> for now, the Destroyed volumes will be expunged in Storage cleanup thread, no 
> matter when they are destroyed.
> In Expunging vm, we only clean the Destroyed vms which have been destroyed at 
> least 'expunge.delay' seconds.
> We need to add the similar configuration for volumes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to