[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008247#comment-15008247
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9047:
--------------------------------------------

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1049#issuecomment-157306100
  
    most network tests passed:
    ```
    Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : FAILED ===
    FAIL
    Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : 
EXCEPTION ===
    ERROR
    Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : 
EXCEPTION ===
    ERROR
    ```
    will look into those.
    
    vpc tests:
    ```
    ----------------------------------------------------------------------
    Ran 42 tests in 11662.679s
    
    OK
    ```


> rename enums to match best practice naming pattern
> --------------------------------------------------
>
>                 Key: CLOUDSTACK-9047
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9047
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Daan Hoogland
>            Assignee: Daan Hoogland
>
> Enums should have a name starting with a capital according to java best 
> practices. Rename those that don't and add unit tests where relevant.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to