[
https://issues.apache.org/jira/browse/CLOUDSTACK-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022280#comment-15022280
]
ASF GitHub Bot commented on CLOUDSTACK-9077:
--------------------------------------------
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1109
CLOUDSTACK-9077 Fix injectkeys.sh to work on CentOS7
Fix regression from commit 3381154fafb7fa4f0a61d538f7c2550e48247787
The error seen on CentOS 7:
```
2015-11-20 21:51:16,161 DEBUG [c.c.s.ConfigurationServerImpl]
(localhost-startStop-1:null) No loop device found, skipping ssh key insertion
in systemvm.iso
```
Instead of detecting `/dev/loop0` this checks if we run inside Docker.
Tested on CentOS 7 and that now works again as expected.
```
2015-11-23 16:20:16,777 DEBUG [c.c.s.ConfigurationServerImpl]
(localhost-startStop-1:null) Executing: /bin/bash
/var/lib/tomcat/webapps/client/WEB-INF/classes/scripts/vm/systemvm/injectkeys.sh
/home/cloud/.ssh/id_rsa.pub /home/cl
oud/.ssh/id_rsa
/var/lib/tomcat/webapps/client/WEB-INF/classes/vms/systemvm.iso
2015-11-23 16:20:16,821 DEBUG [c.c.s.ConfigurationServerImpl]
(localhost-startStop-1:null) Execution is successful.
2015-11-23 16:20:16,827 INFO [c.c.s.ConfigurationServerImpl]
(localhost-startStop-1:null) Injected public and private keys into systemvm iso
with result : null
```
Pinging @pdion891 to have a look.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/remibergsma/cloudstack fix-CLOUDSTACK-9077
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1109
----
commit fe91d9737d8424e6ed93a0c8ed42e58f248e5dc1
Author: Remi Bergsma <[email protected]>
Date: 2015-11-23T12:22:02Z
CLOUDSTACK-9077 Fix injectkeys.sh to work on CentOS7
----
> injectkeys.sh doesn't work on CentOS7
> -------------------------------------
>
> Key: CLOUDSTACK-9077
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9077
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Remi Bergsma
> Priority: Critical
>
> Regression from:
> https://github.com/apache/cloudstack/commit/3381154fafb7fa4f0a61d538f7c2550e48247787
> CentOS7 doesn't have /dev/loop0 so it fails. Removing the check makes it work
> again.
> ```
> 2015-11-20 21:51:16,145 DEBUG [c.c.s.ConfigurationServerImpl]
> (localhost-startStop-1:null) Executing: /bin/bash
> /var/lib/tomcat/webapps/client/WEB-INF/classes/scripts/vm/systemvm/injectkeys.sh
> /usr/share/tomc
> at5/.ssh/id_rsa.pub /usr/share/tomcat5/.ssh/id_rsa
> /var/lib/tomcat/webapps/client/WEB-INF/classes/vms/systemvm.iso
> 2015-11-20 21:51:16,161 DEBUG [c.c.s.ConfigurationServerImpl]
> (localhost-startStop-1:null) Execution is successful.
> 2015-11-20 21:51:16,161 DEBUG [c.c.s.ConfigurationServerImpl]
> (localhost-startStop-1:null) No loop device found, skipping ssh key insertion
> in systemvm.iso
> 2015-11-20 21:51:16,162 INFO [c.c.s.ConfigurationServerImpl]
> (localhost-startStop-1:null) Injected public and private keys into systemvm
> iso with result : null
> ```
> Pinging [~pdion]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
