[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022522#comment-15022522
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8816:
--------------------------------------------

GitHub user ProjectMoon opened a pull request:

    https://github.com/apache/cloudstack/pull/1111

    Fix event UUIDS missing on event bus

    The fixing of CLOUDSTACK-8816 introduced a regression that removed the 
first class entities in the event bus description property. This is because 
everything was changed to use the Class as a key... Everything but the 
populateFirstClassEntities method in ActionEventUtils.
    
    This commit tries to load the class key instead of the String key, which 
re-enables the populateFirstClassEntities method.
    
    Likely this was not caught because of the trace exception handling... maybe 
some better logging/unit tests would be good for this PR.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greenqloud/cloudstack pr-eventbus-entity-uuids

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1111
    
----
commit a528c396d718f0ea6eecbdda7c23c8d7f670d99c
Author: jeff <[email protected]>
Date:   2015-11-23T17:15:57Z

    Fix event UUIDS missing on event bus
    
    The fixing of CLOUDSTACK-8816 introduced a regression that removed the
    first class entities in the event bus description property. This is
    because everything was changed to use the Class as a key... Everything
    but the populateFirstClassEntities method in ActionEventUtils.

----


> rabbitMQ: generated events have wrong or missing uuids
> ------------------------------------------------------
>
>                 Key: CLOUDSTACK-8816
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.3.2, 4.4.4, 4.5.2, 4.6.0
>            Reporter: Rajani Karuturi
>            Assignee: Rajani Karuturi
>            Priority: Critical
>
> For many events, entity uuids are missing. One such example is below. 
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq  for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange      cloudstack-events
> Routing Key   management-server.AsyncJobEvent.complete.Account.*
> Redelivered   ●
> Properties    
> priority:     0
> delivery_mode:        2
> content_type: text/plain
> Payload 885 bytes Encoding: string    
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-0662940000db","user":"fcf71ae6-6983-11e4-bb12-0662940000db"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to