[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030858#comment-15030858
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9083:
--------------------------------------------

Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1121#discussion_r46089207
  
    --- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
---
    @@ -761,6 +766,10 @@ public String toString() {
                 }
                 diskBuilder.append("/>\n");
     
    +            if (_serial != null && !_serial.isEmpty() && _deviceType != 
DeviceType.LUN) {
    --- End diff --
    
    I see, but it is suddenly a new type of disk I haven't seen before in KVM. 
Hence my question.


> Add disk serial to vm/libvirt xml in case of KVM
> ------------------------------------------------
>
>                 Key: CLOUDSTACK-9083
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9083
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>            Priority: Minor
>             Fix For: 4.5.3, 4.7.0, 4.6.1
>
>
> Certain appliances/software fail on KVM as they require disk serials (inside 
> of the VM). The fix would be to add a disk serial (from volume uuid) in the 
> generated libvirt xml for all disks except for lun/scsi block type disks 
> (which we don't support yet, so we can add in a deviceType for now and leave 
> some comment).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to