[
https://issues.apache.org/jira/browse/CLOUDSTACK-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041442#comment-15041442
]
ASF GitHub Bot commented on CLOUDSTACK-9086:
--------------------------------------------
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1125#discussion_r46672603
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -1197,6 +1197,10 @@ public Network createGuestNetwork(CreateNetworkCmd
cmd) throws InsufficientCapac
}
if (gateway != null && netmask != null) {
+ if(!NetUtils.isNetworkorBroadcastIP(gateway,netmask)) {
+ s_logger.debug("The gateway IP provided is "+ gateway
+ " and netmask is "+ netmask + ". The IP is either broadcast or network IP.");
--- End diff --
please, check for isDebugEnabled on s_logger
> ACS allows to create isolated networks with invalid gateway IP address
> ----------------------------------------------------------------------
>
> Key: CLOUDSTACK-9086
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9086
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Kshitij Kansal
> Assignee: Kshitij Kansal
>
> When entering invalid combination no check is performed anymore and VR is
> created with invalid interface. Of course, nothing works in the isolated
> network. For example, you are allowed to create network with 172.16.21.0 IP
> address for GW and 255.255.255.0 for SM - this address is not valid, however
> it is accepted and even used in VR. One more example - 192.168.255.255 for GW
> address and 255.255.255.0 for SM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
