[
https://issues.apache.org/jira/browse/CLOUDSTACK-9106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043467#comment-15043467
]
ASF GitHub Bot commented on CLOUDSTACK-9106:
--------------------------------------------
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761947
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -656,20 +660,22 @@ public static String getHAProxyStickinessCapability()
{
@Override
public boolean applyStaticNats(final Network network, final List<?
extends StaticNat> rules) throws ResourceUnavailableException {
+ boolean result = true;
if (canHandle(network, Service.StaticNat)) {
final List<DomainRouterVO> routers =
_routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
if (routers == null || routers.isEmpty()) {
s_logger.debug("Virtual router elemnt doesn't need to
apply static nat on the backend; virtual " + "router doesn't exist in the
network " + network.getId());
- return true;
+ return result;
}
final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
final NetworkTopology networkTopology =
networkTopologyContext.retrieveNetworkTopology(dcVO);
- return networkTopology.applyStaticNats(network, rules,
routers);
- } else {
- return true;
+ for (final DomainRouterVO domainRouterVO : routers) {
+ result = networkTopology.applyStaticNats(network, rules,
domainRouterVO);
--- End diff --
&=
> As a Developer I want the Redundant VPC private gateway feature fixed
> ---------------------------------------------------------------------
>
> Key: CLOUDSTACK-9106
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9106
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.6.0
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Fix For: 4.7.0
>
>
> Bug in BasicNetworkTopology.applyRules() method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
