[
https://issues.apache.org/jira/browse/CLOUDSTACK-9106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043631#comment-15043631
]
ASF GitHub Bot commented on CLOUDSTACK-9106:
--------------------------------------------
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46765484
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -751,13 +757,15 @@ public boolean savePassword(final Network network,
final NicProfile nic, final V
@Override
public boolean saveSSHKey(final Network network, final NicProfile nic,
final VirtualMachineProfile vm, final String sshPublicKey) throws
ResourceUnavailableException {
+ boolean result = false;
if (!canHandle(network, null)) {
- return false;
+ return result;
}
final List<DomainRouterVO> routers =
_routerDao.listByNetworkAndRole(network.getId(), Role.VIRTUAL_ROUTER);
if (routers == null || routers.isEmpty()) {
s_logger.debug("Can't find virtual router element in network "
+ network.getId());
- return true;
+ result = true;
--- End diff --
Because I do not want to return a literal. And the same for the other
comments.
> As a Developer I want the Redundant VPC private gateway feature fixed
> ---------------------------------------------------------------------
>
> Key: CLOUDSTACK-9106
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9106
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.6.0
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Fix For: 4.7.0
>
>
> Bug in BasicNetworkTopology.applyRules() method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
