[
https://issues.apache.org/jira/browse/CLOUDSTACK-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046605#comment-15046605
]
ASF GitHub Bot commented on CLOUDSTACK-9112:
--------------------------------------------
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1180#issuecomment-162821748
Hi @harikrishna-patnala
Anyway we can test this? Is there any integration test that we can use to
cover your changes? Concerning the new methods you introduced, any chance to
get some unit tests to cover the logic?
Could you describe which steps you followed to test those changes? Would be
nice to come up with some strategy that will help reviewers to test your
changes.
Cheers,
Wilder
> deployVM thread is holding the global lock on network longer and cause delays
> and some improvements in the planner
> ------------------------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9112
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9112
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Harikrishna Patnala
> Assignee: Harikrishna Patnala
> Fix For: 4.7.0
>
>
> There are some VM deployment failures happening when multiple VMs are
> deployed at a time, failures mainly due to NetworkModel code that iterates
> over all the vlans in the pod. This causes each deployVM thread to hold the
> global lock on Network longer and cause delays. This delay in turn causes
> more threads to choose same host and fail since capacity is not available on
> that host.
> Following are some changes required to be done to reduce delays during VM
> deployments which in turn causes some vm deployment failures when multiple
> VMs are launched at a time.
> - In Planner, remove the clusters that do not contain a host with matching
> service offering tag. This will save some iterations over clusters that dont
> have matching tagged host
> - In NetworkModel, do not query the vlans for the pod within the loop. Also
> optimized the logic to query the ip/ipv6
> - In DeploymentPlanningManagerImpl, do not process the affinity group if the
> plan has hostId provided.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
