[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046662#comment-15046662
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9086:
--------------------------------------------

GitHub user kansal opened a pull request:

    https://github.com/apache/cloudstack/pull/1188

    CLOUDSTACK-9086: ACS allows to create isolated networks with invalide…

    … gateway IP address - Fixed and Test cases added
    
    Problem: There was no check for the network and broadcast IP addresses in 
the case where we provide the gateway and netmask while creating the isolated 
network. As a result the provided IP gets assigned to the eth0 interface of the 
VR.
    
    Note: This is in continuation of PR #1125 which I closed. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kansal/cloudstack CLOUDSTACK-9086

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1188
    
----
commit 1b607b9c75bca7ac42086f56d79a6b83fa9d4bc0
Author: Kshitij Kansal <[email protected]>
Date:   2015-12-08T07:31:39Z

    CLOUDSTACK-9086: ACS allows to create isolated networks with invalide 
gateway IP address - Fixed and Test cases added

----


> ACS allows to create isolated networks with invalid gateway IP address
> ----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9086
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9086
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Kshitij Kansal
>            Assignee: Kshitij Kansal
>
> When entering invalid combination no check is performed anymore and VR is 
> created with invalid interface. Of course, nothing works in the isolated 
> network. For example, you are allowed to create network with 172.16.21.0 IP 
> address for GW and 255.255.255.0 for SM - this address is not valid, however 
> it is accepted and even used in VR. One more example - 192.168.255.255 for GW 
> address and 255.255.255.0 for SM.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to