[
https://issues.apache.org/jira/browse/CLOUDSTACK-9130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050092#comment-15050092
]
ASF GitHub Bot commented on CLOUDSTACK-9130:
--------------------------------------------
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1200#discussion_r47190062
--- Diff: core/src/com/cloud/agent/api/RebootCommand.java ---
@@ -19,29 +19,25 @@
package com.cloud.agent.api;
-import com.cloud.vm.VirtualMachine;
-
public class RebootCommand extends Command {
String vmName;
+ protected boolean executeInSequence = false;
protected RebootCommand() {
}
- public RebootCommand(VirtualMachine vm) {
- vmName = vm.getInstanceName();
- }
-
- public RebootCommand(String vmName) {
+ public RebootCommand(String vmName, boolean executeInSequence) {
this.vmName = vmName;
+ this.executeInSequence = executeInSequence;
}
public String getVmName() {
- return vmName;
+ return this.vmName;
}
@Override
public boolean executeInSequence() {
- return true;
+ return this.executeInSequence;
--- End diff --
In StopCommand.java lot of places have 'this.' prefix. Based on that did
changes in RebootCommand as well. I am not sure what the general guideline says
in this regard.
> Make RebootCommand similar to start/stop/migrate agent commands w.r.t.
> "execute in sequence" flag
> -------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9130
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9130
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Koushik Das
> Assignee: Koushik Das
> Fix For: 4.7.0
>
>
> RebootCommand should work in the same way as start/stop/migrate agent
> commands w.r.t. to sequential/parallel execution.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
