[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054570#comment-15054570
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8882:
--------------------------------------------

Github user borisroman commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/859#discussion_r47435639
  
    --- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
    @@ -125,6 +125,25 @@ public UsageVO(Long zoneId, Long accountId, Long 
domainId, String description, S
             this.endDate = endDate;
         }
     
    +    //Network Offering Usage
    +    public UsageVO(Long zoneId, Long accountId, Long domainId, String 
description, String usageDisplay, int usageType, Double rawUsage, Long vmId,
    +                   Long offeringId, Long usageId, Long networkId, Date 
startDate, Date endDate) {
    +        this.zoneId = zoneId;
    +        this.accountId = accountId;
    +        this.domainId = domainId;
    +        this.description = description;
    +        this.usageDisplay = usageDisplay;
    +        this.usageType = usageType;
    +        this.rawUsage = rawUsage;
    +        this.vmInstanceId = vmId;
    +        this.offeringId = offeringId;
    +        this.usageId = usageId;
    +        this.startDate = startDate;
    +        this.endDate = endDate;
    +        this.networkId = networkId;
    +    }
    +
    +
         public UsageVO(Long zoneId, Long accountId, Long domainId, String 
description, String usageDisplay, int usageType, Double rawUsage, Long vmId, 
String vmName,
    --- End diff --
    
    Isn't it possible to extends this one instead of creating a new 
constructor? 


> Network offering usage is sometimes greater than aggregation range
> ------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8882
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8882
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Usage
>            Reporter: Kishan Kavala
>            Assignee: Kishan Kavala
>
> Create a Vm with mutiple nics:
>  - If 2 networks use same network offering, network offering usage will be 
> 48hrs (assuming 24hrs aggregation)
> - Usage should be reported per Nic instead of network offering



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to