[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054972#comment-15054972
 ] 

ASF subversion and git services commented on CLOUDSTACK-9155:
-------------------------------------------------------------

Commit d7b7171870404cfbb1656a043fd42c93726ac8fb in cloudstack's branch 
refs/heads/master from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d7b7171 ]

Merge pull request #1235 from remibergsma/fix-passwd-server-logging

CLOUDSTACK-9155 make sure logrotate is effective for cloud.logMany processes on 
the VRs log to cloud.log. When log rotate kicks in, the file is rotated but the 
scripts still write to the old inode (cloud.log.1 after rotate). Tis quickly 
fills up the tiny log partition.

Using 'copytruncate' is a small tradeoff, there is a slight change of missing a 
log entry, but in the old situation nothing ended up in cloud.log after rotate 
(except for stuff that was (re)started) so I think this is the best solution 
until we properly rewrite the script to either use their own script or syslog.

More details: https://issues.apache.org/jira/browse/CLOUDSTACK-9155

* pr/1235:
  CLOUDSTACK-9155 make sure logrotate is effective

Signed-off-by: Remi Bergsma <[email protected]>


> Log rotate of cloud.log doesn't work properly
> ---------------------------------------------
>
>                 Key: CLOUDSTACK-9155
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9155
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Virtual Router
>    Affects Versions: 4.6.0, 4.7.0, 4.6.1
>            Reporter: Remi Bergsma
>            Assignee: Remi Bergsma
>            Priority: Critical
>             Fix For: 4.7.0, 4.6.2
>
>
> Many processes log into the cloud.log file. When log rotate is called, many 
> of them keep logging to the old inode and fill up the disk like that.
> These have cloud.log open:
> ```
> root@r-1023-VM:~# lsof| grep cloud | awk {'print $1'} | sort -u
> apache2
> conntrack
> keepalive
> logger
> passwd_se
> _plutoloa
> _plutorun
> python
> xl2tpd
> ```
> Current log rotate config:
> ```
> /var/log/cloud.log {
>         rotate 4
>         daily
>         size 10M
>         missingok
>         notifempty
>         compress
>         delaycompress
> }
> ```
> After log rotate this happens:
> ```
> root@r-996-VM:/etc# lsof | grep cloud.log.1
> _plutorun   767          root    3w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> logger      768          root    3w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> _plutorun   772          root    3w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> _plutoloa   773          root    3w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> xl2tpd      843          root    3w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> python      854          root    3w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> passwd_se   860          root    1w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> passwd_se   860          root    2w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> passwd_se   860          root    3w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> python      863          root    3w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> passwd_se   869          root    1w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> passwd_se   869          root    2w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> passwd_se   869          root    3w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> python      871          root    3w      REG             202,10 26054919      
>    71 /var/log/cloud.log.1
> ```



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to