[
https://issues.apache.org/jira/browse/CLOUDSTACK-9146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055022#comment-15055022
]
ASF GitHub Bot commented on CLOUDSTACK-9146:
--------------------------------------------
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164270707
@DaanHoogland @borisroman - I sincerely don't grok the benefits of these
changes, which is why I'm asking what are the benefits of the changes?
Some potential issues I can think of, wrt changing file names and paths
are: (1) doing branch maintenance will become difficult, so cherry-picks and
backporting bugfixes will become error prone, (2) while switching branches IDEs
will be slow as they would need to re-index files/paths, (3) it becomes
difficult to diff across branches (like git diff branch1..branch2
some/file/path/file.txt) as files/paths have changed (I for example run sanity
checks in db related files to make sure we don't change older db paths etc).
While I understand, Maven users want to have convention over configuration,
other than that argument I don't understand the pros. I would request that you
please hold this PR for merging.
> Refactor plugin kvm-hypervisor to default maven structure.
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-9146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9146
> Project: CloudStack
> Issue Type: Sub-task
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Boris Schrijver
> Assignee: Boris Schrijver
>
> Adhere to the default maven directory structure.
> https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
