[
https://issues.apache.org/jira/browse/CLOUDSTACK-9104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055607#comment-15055607
]
ASF GitHub Bot commented on CLOUDSTACK-9104:
--------------------------------------------
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-164374286
@priyankparihar Fair enough, please see a code review comment. Once you fix
the null check, I think your PR is good to go. Also, write a unit test to
enforce the changes; i.e. the unit test should break in future if someone tries
to change the VM naming convention in future.
> VM naming convention in case vmware is used
> -------------------------------------------
>
> Key: CLOUDSTACK-9104
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9104
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Priyank Parihar
>
> ISSUE
> ======
> VM naming convention in case vmware is used.
> Description
> ==========
> User with different account cannot create VMs with the same name, which was
> possible earlier (I am not sure in which CCP version). That time naming
> convention used was like this “I-<user-id>-<Display-Name>”
> Currently if vm.instancename.flag is set to true the VM name will be exactly
> as display name given.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)