[
https://issues.apache.org/jira/browse/CLOUDSTACK-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055762#comment-15055762
]
ASF GitHub Bot commented on CLOUDSTACK-9161:
--------------------------------------------
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1240#discussion_r47480556
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -186,7 +186,7 @@ public int compare(QuotaBalanceVO o1, QuotaBalanceVO
o2) {
//check that there is at least one balance entry
for (Iterator<QuotaBalanceVO> it = quotaBalance.iterator();
it.hasNext();) {
QuotaBalanceVO entry = it.next();
- if (entry.getCreditsId() > 0) {
+ if (entry.getCreditsId() == 0) {
--- End diff --
So in every set of balance entries between any start and end date there is
supposed to be one with creditId == 0?
Also whether one or none are found this loop ends. How does this check work?
> Quota Service: fix marvin test
> ------------------------------
>
> Key: CLOUDSTACK-9161
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9161
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.7.0
> Reporter: Abhinandan Prateek
> Assignee: Abhinandan Prateek
> Priority: Critical
> Fix For: 4.7.0
>
>
> the two tests in test_quota.py marvin tests are failing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
