[
https://issues.apache.org/jira/browse/CLOUDSTACK-9132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088854#comment-15088854
]
ASF GitHub Bot commented on CLOUDSTACK-9132:
--------------------------------------------
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1319
CLOUDSTACK-9132: API createVolume takes empty string for name parameter
Steps to Reproduce:
================
Create a volume using createVolume API where parameter name is empty.
It creates a volume with empty name.
But the name parameter is mandatory.(Issue)
Expected Behaviour:
================
It shouldn't create a volume with an empty name. Error should be returned.
Solution:
=======
Added a condition to check in case of empty string. If the name is an empty
string, it generates a random name for the volume. Made the name field optional
in UI as well as in API.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitin-maharana/CloudStack
CloudStack-Nitin15_4.7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1319.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1319
----
commit 55f8b32aa00baf0609f54891230269ed97bedb5a
Author: Nitin Kumar Maharana <[email protected]>
Date: 2015-12-29T11:15:41Z
CLOUDSTACK-9132: API createVolume takes empty string for name parameter
Added conditions to check if the name is empty or blank.
If it is empty or blank, then it generates a random name.
Made the name field as optional in UI as well as in API.
Added required unit tests.
----
> API createVolume takes empty string for name parameter
> ------------------------------------------------------
>
> Key: CLOUDSTACK-9132
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9132
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Reporter: Nitin Kumar Maharana
>
> Steps to Reproduce:
> ================
> Create a volume using createVolume API where parameter name is empty.
> It creates a volume with empty name.
> But the name parameter is mandatory.(Issue)
> Expected Behaviour:
> ================
> It shouldn't create a volume with an empty name. Error should be returned.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
