[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088894#comment-15088894
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8847:
--------------------------------------------

GitHub user nitin-maharana opened a pull request:

    https://github.com/apache/cloudstack/pull/1321

    CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged 
offerings when called with VM id

    When calling listServiceOfferings with VM id as parameter. It is returning 
incompatible tagged offerings. It should only list all compatible tagged 
offerings. Compatible means the new service offering should contain all the 
tags of the existing service offering(Existing offering SUBSET of new 
offering). If that is the case It should list in the result and can be upgraded 
to that offering.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nitin-maharana/CloudStack 
CloudStack-Nitin5_4.7

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1321
    
----
commit ba0503d000250e233701a71bd8e406e52b6ad110
Author: Nitin Kumar Maharana <[email protected]>
Date:   2015-09-14T16:32:37Z

    CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged 
offerings when called with VM id
    
    Fixed the subset and superset issue.
    Added unit test for the same.

----


> ListServiceOfferings is returning incompatible tagged offerings when called 
> with VM id
> --------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8847
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8847
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Nitin Kumar Maharana
>
> When calling listServiceOfferings with VM id as parameter. It is returning 
> incompatible tagged offerings. It should only list all compatible tagged 
> offerings. The new service offering should contain all the tags of the 
> existing service offering. If that is the case It should list in the result.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to