[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096634#comment-15096634
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9235:
--------------------------------------------

Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1337#issuecomment-171373038
  
    Hi @nitin-maharana, 
    What about a little change in your code?
    
    The complexity of that if/else structure that you are working on is too big.
    
    I believe that you can extract the code from lines 3673-3686 to a method 
that returns a Boolean indicating if there is a provider named “NetScaler”. 
Then you could do something like : 
    var lbProviderIsNetscaler = checkIfNetscalerProviderIsEnabled (services);



> Autoscale button is missing in VPC
> ----------------------------------
>
>                 Key: CLOUDSTACK-9235
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9235
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Nitin Kumar Maharana
>
> Autoscale button is missing. This should not be the case since we are able to 
> add NS as the external LB provider in VPC.
> Steps:
> =====
> 1. Create a VPC offering with NS as the external LB provider
> 2. Create a VPC and configure the public tier with the above offering
> 3. Acquire an IP address and try to configure Load Balancing rule
> Result:
> ======
> Autoscale option is not visible at all for the LB.
> Expected Result:
> =============
> Autoscale option should be available and should work exactly like the way it 
> works for a normal isolated network with NS. If we choose NS as service 
> provider for LB, autoscale should also be visible. If VR is chosen, only then 
> we should not display autoscale.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to