[
https://issues.apache.org/jira/browse/CLOUDSTACK-9238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103311#comment-15103311
]
ASF GitHub Bot commented on CLOUDSTACK-9238:
--------------------------------------------
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1341#issuecomment-172244406
This page has some interesting background:
http://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers
It seems URLs can be much longer. The question is whether we need those in
CloudStack. For now I'm OK with 2K instead of 256. We can always bump them
later when needed.
LGTM
> URL fields in database are to small. Cause malformed URLs
> ---------------------------------------------------------
>
> Key: CLOUDSTACK-9238
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9238
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0, 4.7.0, 4.8.0
> Reporter: Wido den Hollander
> Assignee: Wido den Hollander
> Labels: s3, template, templates, url, urls
> Fix For: 4.8.0
>
>
> In for example the 'volume_store_ref' table the 'download_url' field is a
> VARCHAR(255).
> This is to short for URLs. Same goes for the 'object_datastore_ref' table and
> the 'url' field.
> With pre-signed S3 URLs this will cause issues.
> The fix would be to change the database fields to a VARCHAR(2048). No
> code-change is required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
