[jira] [Commented] (CLOUDSTACK-9236) Load Balancing Health Check button displayed when non-NetScaler offering is used

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105364#comment-15105364
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9236:
--------------------------------------------

Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1338#issuecomment-172545747
  
    LGTM based on these tests:
    
    Situation before when not using Netscaler:
    
    ![screen shot 2016-01-18 at 15 37 
25](https://cloud.githubusercontent.com/assets/1630096/12394040/baae8bc6-bdf9-11e5-9443-23ff6f2c42cb.png)
    
    ![screen shot 2016-01-18 at 15 34 
47](https://cloud.githubusercontent.com/assets/1630096/12394036/b5cc0b38-bdf9-11e5-9fc2-c29197c504ee.png)
    
    ![screen shot 2016-01-18 at 15 34 
58](https://cloud.githubusercontent.com/assets/1630096/12394044/c048925c-bdf9-11e5-9188-b694f823332c.png)
    
    Basically, the button is displayed but throws an ugly message.
    
    After the fix in this PR the button is hidden:
    
    ![screen shot 2016-01-18 at 15 38 
46](https://cloud.githubusercontent.com/assets/1630096/12394060/cffca7f6-bdf9-11e5-9c87-7cc739f5cc8e.png)
    
    Didn't test if it shows when using Netscaler, as I don't have it in my test 
environment.


> Load Balancing Health Check button displayed when non-NetScaler offering is 
> used
> --------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9236
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9236
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Nitin Kumar Maharana
>
> Load balancing health check option / button should only be displayed when a 
> NetScaler based networking offering is being used. 
> If you try to use the health check option when NetScaler is not being used as 
> the load balancing technology the UI throws an error stating that the health 
> check option is not supported. 
> This button / option should be removed from the UI if NetScaler is not 
> included in the network offering as customers will be confused. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)