[
https://issues.apache.org/jira/browse/CLOUDSTACK-9245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116803#comment-15116803
]
ASF subversion and git services commented on CLOUDSTACK-9245:
-------------------------------------------------------------
Commit 1e4bc9ae9d8c5392617b68258af4a7edb75e8ce3 in cloudstack's branch
refs/heads/4.7 from [~remibergsma]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1e4bc9a ]
Merge pull request #1358 from ekholabs/fix/4.7-acl-delete-CLOUDSTACK-9245
CLOUDSTACK-9245 - Cannot delete non-attached ACL that contains itemsThis PR
fixes the issue when trying to delete ACL lists which contain item.
It seemed it was not thought of when the ACS project started, when most user
were relying on the UI to execute those tasks. Nowadays, with automation all
over the place and ACL lists containing hundreds of items, it's very hard to
have to delete them 1 by 1 either via the UI. Writing scripts to do so might be
a solution, but it would be much simpler to just delete non-attached ACLs with
all its items in one go.
Also, destroying a VPC that contains ACL lists was "succeeding", but after that
the ACL list/items were messing up:
```
list networkacls aclid=920d74b6-4d15-454f-b3a6-61e7a6ffd1a4
Error 431: Unable to find VPC associated with acl
{
"cserrorcode": 4350,
"errorcode": 431,
"errortext": "Unable to find VPC associated with acl",
"uuidList": []
}
```
So, it also cleans up ACLs when destroying VPCs
* pr/1358:
CLOUDSTACK-9245 - Deletes ACL items when destroying the VPC or deleting the
ACL itself
CLOUDSTACK-9245 - Formatting NetworkACLServiceImpl class
CLOUDSTACK-9245 - Formatting VpcManagerImpl class
CLOUDSTACK-9245 - Formatting NetworkACLManagerImpl class
Signed-off-by: Remi Bergsma <[email protected]>
> As an User I want to be able to delete non-attached ACL lists that contain
> items
> --------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9245
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9245
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VPC
> Affects Versions: 4.5.0, 4.6.0, 4.7.0
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Fix For: 4.7.1
>
>
> Create a VPC, add a network, create an ACL, add items to the ACL, attached
> the ACL to the network.
> Trying to delete it should fail, and it actually does. That's expected.
> Now detach the ACL from the network, delete the network, try to delete the
> ACL. It fails because the ACL contains item.
> If we delete the VPC, the ACL is also deleted. We want to simply delete the
> ACL and its items in one go.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
