[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135401#comment-15135401
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8855:
--------------------------------------------

Github user rodrigo93 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/837#discussion_r52094072
  
    --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
    @@ -1148,15 +1148,16 @@ public Host cancelMaintenance(final 
CancelMaintenanceCmd cmd) {
         }
     
         @Override
    -    public Host reconnectHost(final ReconnectHostCmd cmd) {
    -        final Long hostId = cmd.getId();
    +    public Host reconnectHost(ReconnectHostCmd cmd) throws 
CloudRuntimeException, AgentUnavailableException{
    --- End diff --
    
    Does this method need to return a host? It seems that it just reconnects to 
a host, if not, throws an exception.
    If so, it could be void as well.


> Improve Error Message for Host Alert State
> ------------------------------------------
>
>                 Key: CLOUDSTACK-8855
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.6.0
>            Reporter: Bharat Kumar
>            Assignee: Bharat Kumar
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to