[
https://issues.apache.org/jira/browse/CLOUDSTACK-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136078#comment-15136078
]
ASF GitHub Bot commented on CLOUDSTACK-8870:
--------------------------------------------
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/846#discussion_r52110260
--- Diff: server/src/com/cloud/network/ExternalDeviceUsageManagerImpl.java
---
@@ -342,6 +342,12 @@ public ExternalDeviceNetworkUsageTask() {
@Override
protected void runInContext() {
+ //Check if there are any external deivces
+ //Skip external device usage collection if none exist
--- End diff --
@kishankavala Could you please change from "deivces" to "devices"?
Also, you can use this commented lines as a Javadoc block describing the
runInContext() method (if you think it would improve your code).
Except that typo, your code seems ok.
> external network device usage monitor runs even when there are no external
> devices
> ----------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8870
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8870
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Kishan Kavala
> Assignee: Kishan Kavala
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
