[
https://issues.apache.org/jira/browse/CLOUDSTACK-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173968#comment-15173968
]
ASF GitHub Bot commented on CLOUDSTACK-9298:
--------------------------------------------
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-190791313
@nvazquez, nice changes.
So, I guess that a test cases for these new methods will be important to
detect future changes in these methods behavior.
Another thing, is this new constructor really necessary? do you use this
constructor in any part of the code? or do you just created this constructor to
improve future codes calling only this constructor instead of lots of setters
as you said?
In my opinion, a constructor with many params is a bit ugly, I prefer to
use no params in the constructor and use some factory pattern to create this
object (lots of setters called inside a factory class), this is just my opinion.
Ty.
> Improve performance of resource retrieval that have tags associated and
> target volumes, VMs and templates
> ---------------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9298
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9298
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Affects Versions: 4.9.0
> Reporter: Nicolas Vazquez
> Fix For: 4.9.0
>
>
> h2. Description of the problem
> When retrieving a large number of resources which have tags associated with,
> retrieval methods took too long. Our goal is to improve performance of this
> methods
> h3. ListTemplatesCmd API method
> It is proposed to include tags information into template_view to avoid
> querying the database for each tag, managing that information in memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
