[
https://issues.apache.org/jira/browse/CLOUDSTACK-9319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208329#comment-15208329
]
ASF GitHub Bot commented on CLOUDSTACK-9319:
--------------------------------------------
GitHub user insom opened a pull request:
https://github.com/apache/cloudstack/pull/1451
CLOUDSTACK-9319: Use timeout when applying config to virtual router
From the [JIRA
issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9319):
> The timeout parameter is not passed down to `applyConfigToVR` inside
`VirtualRoutingResource` in all cases.
>
> This timeout is worked out as 3 seconds per command or 120 seconds
(whichever is larger), but because it's not passed to the first invocation, the
default (120 seconds, DEFAULT_EXECUTEINVR_TIMEOUT) is used.
>
> In a recent upgrade of our Virtual Routers, the timeout was being hit and
increasing `router.aggregation.command.each.timeout` had no effect. I built a
custom 4.8 agent with the timeout increased to allow the upgrade to continue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/insom/cloudstack CLOUDSTACK-9319
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1451.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1451
----
commit 9f353b4672c0f875b7f64b4d1fadd458ff9abad3
Author: Aaron Brady <[email protected]>
Date: 2016-03-23T12:15:24Z
Use timeout when applying config to virtual router
----
> Timeout is not passed to virtual router operations consistently
> ---------------------------------------------------------------
>
> Key: CLOUDSTACK-9319
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9319
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.8.0
> Environment: KVM + Ceph cloud, Ubuntu hosts.
> Reporter: Aaron Brady
> Priority: Trivial
>
> The timeout parameter is not passed down to `applyConfigToVR` inside
> `VirtualRoutingResource` in all cases.
> This timeout is worked out as 3 seconds per command or 120 seconds (whichever
> is larger), but because it's not passed to the first invocation, the default
> (120 seconds, DEFAULT_EXECUTEINVR_TIMEOUT) is used.
> In a recent upgrade of our Virtual Routers, the timeout was being hit and
> increasing `router.aggregation.command.each.timeout` had no effect. I built a
> custom 4.8 agent with the timeout increased to allow the upgrade to continue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
