[
https://issues.apache.org/jira/browse/CLOUDSTACK-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214084#comment-15214084
]
ASF GitHub Bot commented on CLOUDSTACK-9328:
--------------------------------------------
Github user shwetaag commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1455#discussion_r57562054
--- Diff: test/integration/smoke/test_privategw_acl.py ---
@@ -287,6 +298,16 @@ def performVPCTests(self, vpc_off,
restart_with_cleanup = False):
if not physical_networks:
self.fail("No Physical Networks found!")
+ qresultset = self.dbclient.execute(
+ "select vnet from op_dc_vnet_alloc where physical_network_id=\
+ (select id from physical_network where uuid='%s' ) and taken
is NULL;" % physical_networks[0].id
+ )
+ self.assertEqual(validateList(qresultset)[0],
+ PASS,
+ "Invalid sql query response"
+ )
+ #vlans = physical_networks[0].vlan.split('-')
+ vlans = qresultset
vlans = physical_networks[0].vlan.split('-')
--- End diff --
this split is not needed for getting correct vlan entry
> Fix vlan issues from test suite test_privategw_acl.py in BVT
> ------------------------------------------------------------
>
> Key: CLOUDSTACK-9328
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9328
> Project: CloudStack
> Issue Type: Test
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Automation
> Reporter: Sanjeev N
> Assignee: Sanjeev N
>
> Fix vlan issues from test suite test_privategw_acl.py in BVT
> Currently the tests reads the vlans from the physical network and takes the
> first vlan from the list of vlans and uses it. However, this approach might
> not work when the tests run in parallel. E.g. in CI we run test suits in
> parallel and the first vlan may not be available and tests would fail if we
> try to use the vlan which is already in use.
> Made changes to the script so that it will get the free vlan list from the DB
> and uses the first vlan from the available pool.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
