[
https://issues.apache.org/jira/browse/CLOUDSTACK-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220969#comment-15220969
]
ASF GitHub Bot commented on CLOUDSTACK-9314:
--------------------------------------------
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1443#issuecomment-204199455
It is a nice clean up, thanks @GabrielBrascher
> Remove unused code from XenServerStorageProcessor and change methods access
> level
> ---------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9314
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9314
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: XenServer
> Affects Versions: 4.9.0
> Reporter: Gabriel Beims Bräscher
> Priority: Trivial
>
> Remove unused code from
> "com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor" class and
> modify some methods access level.
> Remove unused methods:
>
> com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getSRByNameLabel(Connection,
> String)
>
> com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getNfsSR(Connection,
> StorageFilerTO)
>
> com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.directDownloadHttpTemplate(CopyCommand,
> DecodedDataObject, DecodedDataObject)
>
> com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.execute(AttachPrimaryDataStoreCmd)
> change access level:
> from public to private:
> com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.swiftUpload(Connection,
> SwiftTO, String, String, String, Boolean, int)
> from public to protected:
> com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.swiftBackupSnapshot(Connection,
> SwiftTO, String, String, String, Boolean, int)
> from protected to private:
> com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getSnapshotSize(Connection,
> String, String, Boolean, int)
> from protected to private:
> com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.backupSnapshot(Connection,
> String, String, String, String, String, String, Boolean, int)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
