[
https://issues.apache.org/jira/browse/CLOUDSTACK-8800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224124#comment-15224124
]
ASF GitHub Bot commented on CLOUDSTACK-8800:
--------------------------------------------
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r58375427
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
---
@@ -484,6 +489,10 @@ public DomainBlockStats answer(final InvocationOnMock
invocation) throws Throwab
// IO traffic as generated by the logic above, must be greater
than zero
Assert.assertTrue(vmStat.getDiskReadKBs() > 0);
Assert.assertTrue(vmStat.getDiskWriteKBs() > 0);
+ // Memory limit of VM must be greater than zero
--- End diff --
I have read and given some time to think about this test. It is very big
and complicated, but those are other issues that are due to the method itself
that is being tested.
About the test coditional, I believe that the “>=” is right. Because if you
are checking the freeMemory, that method can return zero (0) in cases that you
are using all of the memory that is being allocated to the VM. I think that the
comment in the test case is misleading us.
> Improve the listVirtualMachines API call to include memory utilization
> information for a VM
> -------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8800
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8800
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.5.2
> Reporter: Maneesha
> Assignee: Maneesha
> Fix For: 4.6.1
>
>
> Currently the feature of memory utilization is not available via API call
> (listVirtualMachines).
> https://cloudstack.apache.org/api/apidocs-4.5/root_admin/listVirtualMachines.html
>
> The listVirtualMachine get its values from the "user_vm_view" table in the
> database. Currently it shows the CPU utilization of the VM's.
> The only way to find out the memory utilization of VM's running on XenServer,
> is to run the "xentop" command on the pool master of the cluster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
