[
https://issues.apache.org/jira/browse/CLOUDSTACK-8611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224495#comment-15224495
]
ASF GitHub Bot commented on CLOUDSTACK-8611:
--------------------------------------------
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58407949
--- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java ---
@@ -0,0 +1,131 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.utils.ssh;
+
+import java.io.InputStream;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mockito;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import com.trilead.ssh2.ChannelCondition;
+import com.trilead.ssh2.Session;
+
+@RunWith(MockitoJUnitRunner.class)
+public class SshHelperTest {
+
+ // throwSshExceptionIfConditionsTimeout tests
+ @Test(expected = SshException.class)
+ public void throwSshExceptionIfConditionsTimeoutTestTimeout() throws
SshException {
+
SshHelper.throwSshExceptionIfConditionsTimeout(ChannelCondition.TIMEOUT);
+ }
+
+ @Test
+ public void throwSshExceptionIfConditionsTimeoutTestClosed() throws
SshException {
+
SshHelper.throwSshExceptionIfConditionsTimeout(ChannelCondition.CLOSED);
+ }
+
+ @Test
+ public void throwSshExceptionIfConditionsTimeoutTestStdout() throws
SshException {
+
SshHelper.throwSshExceptionIfConditionsTimeout(ChannelCondition.STDOUT_DATA);
+ }
+
+ @Test
+ public void throwSshExceptionIfConditionsTimeoutTestStderr() throws
SshException {
+
SshHelper.throwSshExceptionIfConditionsTimeout(ChannelCondition.STDERR_DATA);
+ }
+
+ @Test
+ public void throwSshExceptionIfConditionsTimeoutTestEof() throws
SshException {
+
SshHelper.throwSshExceptionIfConditionsTimeout(ChannelCondition.EOF);
+ }
+
+ @Test
+ public void throwSshExceptionIfConditionsTimeoutTestExitStatus()
throws SshException {
+
SshHelper.throwSshExceptionIfConditionsTimeout(ChannelCondition.EXIT_STATUS);
+ }
+
+ @Test
+ public void throwSshExceptionIfConditionsTimeoutTestExitSignal()
throws SshException {
+
SshHelper.throwSshExceptionIfConditionsTimeout(ChannelCondition.EXIT_SIGNAL);
+ }
+
+ // isChannelConditionEof tests
+ @Test
+ public void isChannelConditionEofTestTimeout() {
+
Assert.assertFalse(SshHelper.isChannelConditionEof(ChannelCondition.TIMEOUT));
+ }
+
+ @Test
+ public void isChannelConditionEofTestClosed() {
+
Assert.assertFalse(SshHelper.isChannelConditionEof(ChannelCondition.CLOSED));
+ }
+
+ @Test
+ public void isChannelConditionEofTestStdout() {
+
Assert.assertFalse(SshHelper.isChannelConditionEof(ChannelCondition.STDOUT_DATA));
+ }
+
+ @Test
+ public void isChannelConditionEofTestStderr() {
+
Assert.assertFalse(SshHelper.isChannelConditionEof(ChannelCondition.STDERR_DATA));
+ }
+
+ @Test
+ public void isChannelConditionEofTestEof() {
+
Assert.assertTrue(SshHelper.isChannelConditionEof(ChannelCondition.EOF));
+ }
+
+ @Test
+ public void isChannelConditionEofTestExitStatus() {
+
Assert.assertFalse(SshHelper.isChannelConditionEof(ChannelCondition.EXIT_STATUS));
+ }
+
+ @Test
+ public void isChannelConditionEofTestExitSignal() {
+
Assert.assertFalse(SshHelper.isChannelConditionEof(ChannelCondition.EXIT_SIGNAL));
+ }
+
+ // throwSshExceptionIfStdoutOrStdeerIsNull tests
+ @Test(expected = SshException.class)
+ public void throwSshExceptionIfStdoutOrStdeerIsNullTestNull() throws
SshException {
+ SshHelper.throwSshExceptionIfStdoutOrStdeerIsNull(null, null);
+ }
+
+ @Test
+ public void throwSshExceptionIfStdoutOrStdeerIsNullTestNotNull()
throws SshException {
+ InputStream inputStream = Mockito.mock(InputStream.class);
+ SshHelper.throwSshExceptionIfStdoutOrStdeerIsNull(inputStream,
inputStream);
+ }
+
+ // throwSshExceptionIfSshConnectionIsNull tests
+ @Test
+ public void throwSshExceptionIfSshConnectionIsNullTestNotNull() throws
InterruptedException, SshException {
+ Session sess = Mockito.mock(Session.class);
+ SshHelper.throwSshExceptionIfSshConnectionIsNull(sess);
--- End diff --
no asserts here?
> CS waits indefinitely for CheckS2SVpnConnectionsCommand to return
> -----------------------------------------------------------------
>
> Key: CLOUDSTACK-8611
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8611
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Likitha Shetty
> Assignee: Suresh Kumar Anaparti
> Fix For: 4.6.1
>
>
> On one instance, CS began to execute CheckS2SVpnConnectionsCommand command on
> a router but the command result was never returned to the MS. If a command
> never returns, then 'DirectAgent' thread executing this command is blocked
> indefinitely and cannot pick up any other request.
> Now since this command is designed to execute in sequence on a host and is
> run regularly, every execution of that command thereafter on that particular
> host ended up picking up a DirectAgent thread and waiting for the previous
> execution to complete. And hence overtime, the host ended up using and
> blocking all 'DirectAgent' threads indefinitely.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
