[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235020#comment-15235020
 ] 

ASF subversion and git services commented on CLOUDSTACK-9297:
-------------------------------------------------------------

Commit f33b4a1b687775e435baf292d9d49c0f0a418538 in cloudstack's branch 
refs/heads/4.7 from [[email protected]]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f33b4a1 ]

Merge pull request #1441 from mike-tutkowski/4.7

CLOUDSTACK-9297 - Reworked logic in StorageSystemSnapshotStrategy and 
XenserverSnapshotStrategyThe ticket this PR fixes was opened because 
KVM-specific code had been added to the StorageSystemSnapshotStrategy class and 
that class' canHandle method was only prepared to handle managed storage being 
used with XenServer (and a case was hit for KVM that triggered a 
CloudRuntimeException to be thrown).

To solve the problem, I moved the KVM logic to the default snapshot strategy 
class, which is (unfortunately) named XenserverSnapshotStrategy.

I plan to rename XenserverSnapshotStrategy to something like 
DefaultSnapshotStrategy in 4.9.

My guess is that when XenserverSnapshotStrategy was originally written, it was 
written only for XenServer, but has since that time had its usage increased to 
support other hypervisors (with non-managed storage).

* pr/1441:
  CLOUDSTACK-9297: delete snapshot without id is failing with Unable to 
determine the storage pool of the snapshot

Signed-off-by: Will Stevens <[email protected]>


> delete snapshot without id is failing with Unable to determine the storage 
> pool of the snapshot
> -----------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9297
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9297
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: API
>    Affects Versions: 4.7.0, 4.8.0
>         Environment: Ubuntu 14.04.3 management + kvm
>            Reporter: Özhan Rüzgar Karaman
>            Assignee: Mike Tutkowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to