[
https://issues.apache.org/jira/browse/CLOUDSTACK-9343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234327#comment-15234327
]
pedro henrique pereira martins edited comment on CLOUDSTACK-9343 at 4/12/16
5:58 PM:
-------------------------------------------------------------------------------------
This issue was detected during the analysis of this PR
https://github.com/apache/cloudstack/pull/1278/files
It was removed some unused params User & Account in the
com.cloud.network.router.NetworkHelper.startVirtualRouter(DomainRouterVO, User,
Account, Map) and the param Long in the
com.cloud.network.router.NetworkHelper.destroyRouter(long, Account, Long)
Also, it was removed some unused params User & Account from
com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO, User, Account,
Map, DeploymentPlan)
was (Author: pedro-martins):
It was removed some unused params User & Account in the
com.cloud.network.router.NetworkHelper.startVirtualRouter(DomainRouterVO, User,
Account, Map) and the param Long in the
com.cloud.network.router.NetworkHelper.destroyRouter(long, Account, Long)
Also, it was removed some unused params User & Account from
com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO, User, Account,
Map, DeploymentPlan)
> Remove the unused parameters and variable from NetworkHelper hierarchy
> ----------------------------------------------------------------------
>
> Key: CLOUDSTACK-9343
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9343
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Devices
> Affects Versions: 4.6.0
> Reporter: pedro henrique pereira martins
> Assignee: pedro henrique pereira martins
> Priority: Trivial
> Fix For: 4.9.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
