[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242776#comment-15242776
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8562:
--------------------------------------------

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1489#discussion_r59856583
  
    --- Diff: 
api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ---
    @@ -117,6 +123,12 @@ public long getEntityOwnerId() {
     
         @Override
         public void execute() {
    +        if (Strings.isNullOrEmpty(getCfgName())) {
    +            throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Empty 
configuration name provided");
    +        }
    +        if 
(getCfgName().equalsIgnoreCase(RoleService.EnableDynamicApiChecker.key())) {
    +            throw new ServerApiException(ApiErrorCode.METHOD_NOT_ALLOWED, 
"Restricted configuration update not allowed");
    --- End diff --
    
    fixed


> User Definable Roles
> --------------------
>
>                 Key: CLOUDSTACK-8562
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>            Reporter: Paul Angus
>            Assignee: Rohit Yadav
>
> Static command.properties moved to database and made user definable



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to