[
https://issues.apache.org/jira/browse/CLOUDSTACK-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248038#comment-15248038
]
ASF GitHub Bot commented on CLOUDSTACK-9351:
--------------------------------------------
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-211994713
The method name is ok. I just asked to confirm how you see the method
workings. I only feel that the Javadoc should say that, whenever the ID
variable is not null, it is the only one that is going to be used and returned
in the List. Also, we should have a test for that.
> Add ids parameter to resource listing API calls
> -----------------------------------------------
>
> Key: CLOUDSTACK-9351
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9351
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Affects Versions: 4.9.0
> Reporter: Nicolas Vazquez
> Fix For: 4.9.0
>
>
> h2. General behaviour
> A new parameter is added in each method, its type a list of IDs of the
> entity, it will be mutually exclusive with id. (Similar to {{id}} and {{ids}}
> parameters in {{listVirtualMachines}} method)
> h3. API Methods affected
> * +{{listTemplates}}+: new parameter *{{ids}}*, mutually exclusive with {{id}}
> * +{{listVolumes}}+: new parameter *{{ids}}*, mutually exclusive with {{id}}
> * +{{listSnapshots}}+: new parameter *{{ids}}*, mutually exclusive with {{id}}
> * +{{listVMSnapshots}}+: new parameter *{{vmsnapshotids}}*, mutually
> exclusive with {{vmsnapshotid}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
