[
https://issues.apache.org/jira/browse/CLOUDSTACK-9104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251707#comment-15251707
]
ASF GitHub Bot commented on CLOUDSTACK-9104:
--------------------------------------------
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60561591
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
return new String[] {datastoreDiskPath};
}
- // Pair<internal CS name, vCenter display name>
- private Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) {
- String vmInternalCSName = vmSpec.getName();
- String vmNameOnVcenter = vmSpec.getName();
- if (_instanceNameFlag && vmSpec.getHostName() != null) {
- vmNameOnVcenter = vmSpec.getHostName();
+
+ /**
+ * This method generates VM name for Vcenter and Cloudstack( when
Hypervisor is VMware).
+ * It generates VM name according to _instanceNameFlag setting.
+ *
+ * @param VirtualMachineTO
+ * vmSpec
+ * @return Pair<internal CS name, vCenter display name>. A pair which
contain 'internal CS name' and
+ * 'vCenter display name'(vCenter knows VM by this name).
+ **/
+ private Pair<String, String> composeVmNatmes(VirtualMachineTO vmSpec) {
+
+ String vmInternalCSName = null;
+ String vmNameOnVcenter = null;
+ if(vmSpec != null)
+ {
+ vmInternalCSName = vmNameOnVcenter = vmSpec.getName();
+ if (_instanceNameFlag == true &&
vmSpec.getType()==VirtualMachine.Type.User) {
+ String[] tokens = vmInternalCSName.split("-");
+ assert (tokens.length >= 3); // vmInternalCSName has
format i-x-y-<instance.name>
--- End diff --
Because assertions may be disabled, programs must not assume that the
boolean expression contained in an assertion will be evaluated. Try to check it
as well.
> VM naming convention in case vmware is used
> -------------------------------------------
>
> Key: CLOUDSTACK-9104
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9104
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Priyank Parihar
>
> ISSUE
> ======
> VM naming convention in case vmware is used.
> Description
> ==========
> User with different account cannot create VMs with the same name, which was
> possible earlier (I am not sure in which CCP version). That time naming
> convention used was like this “I-<user-id>-<Display-Name>”
> Currently if vm.instancename.flag is set to true the VM name will be exactly
> as display name given.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
