[
https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254663#comment-15254663
]
ASF GitHub Bot commented on CLOUDSTACK-8562:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60801905
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
---
@@ -119,6 +131,9 @@ private Long getDomainId() {
@Override
public void execute() throws ServerApiException {
+ if (getAccountType() == null && getRoleId() == null) {
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Both
account type and role ID are not provided");
--- End diff --
@bhaisaab this check seems more restrictive than the previous version.
Before this change, ``accountType`` was completely optional. With this change,
an script using this API call that did not include ``accountType`` and wouldn't
include ``roleId``because it is a new parameter would fail.
> User Definable Roles
> --------------------
>
> Key: CLOUDSTACK-8562
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Reporter: Paul Angus
> Assignee: Rohit Yadav
>
> Static command.properties moved to database and made user definable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
