[
https://issues.apache.org/jira/browse/CLOUDSTACK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261758#comment-15261758
]
ASF GitHub Bot commented on CLOUDSTACK-8562:
--------------------------------------------
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-215352448
@DaanHoogland @wido @mlsorensen @jburwell @agneya2001 @koushik-das
@terbolous @resmo @K0zka review and LGTM please?
@swill I think we've resolved all outstanding concerns, and if there are
still any concern that should be shared, summary;
- Existing users are not migrated automatically, they continue to use
static-checker, @koushik-das raised concern if dynamic-checker is forced upon
users -- it is not
- Commands.properties file is only removed from codebase, after an upgrade
this file won't be removed by the deb/rpm packages, @koushik-das raised concern
on not removing it -- it is clarified that it's not for users with existing
deployments
- Valid points raised by @mlsorensen on why dynamic checker is the way
forward and static-checker has several pain points for real world users
- @koushik-das raised concerns about code quality and testing, my colleague
@borisstoyanov and I have spent good time to test the feature against ldap,
saml and native cloudstack authentication; along with upgrade and regression
tests around the feature. The integration test runs with Travis as well,
providing nearly 100% coverage
> User Definable Roles
> --------------------
>
> Key: CLOUDSTACK-8562
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8562
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Reporter: Paul Angus
> Assignee: Rohit Yadav
>
> Static command.properties moved to database and made user definable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
