[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262876#comment-15262876
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9340:
--------------------------------------------

Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1466#issuecomment-215546030
  
    @nvazquez, 
    What does that mean?
    
    First we are executing all of the `schema-XXXtoYYY.sql`, then all of the 
`schemaXXXtoYYY-cleanup.sql`? Instead of` schema-XXXtoYYY.sql, 
schemaXXXtoYYY-cleanup.sql` and then `schema-XXX+1toYYY+1.sql, 
schemaXXX+1toYYY+1-cleanup.sql`
    
    I have just looked at the code at 
"com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(String, String)", that is 
exactly what happens.
    First we are executing all of the `schema-XXXtoYYY.sql`, then all of the 
`schemaXXXtoYYY-cleanup.sql`
    
    So, I am ok with your changes to create the "schema-410to420-cleanup.sql"
    
    So, I am ok with you moving some scripts to 



> General DB Optimization
> -----------------------
>
>                 Key: CLOUDSTACK-9340
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9340
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.9.0
>            Reporter: Nicolas Vazquez
>              Labels: database
>             Fix For: 4.9.0
>
>
> h2. General DB Optimization
> In some production environments there were being experimented delays in most 
> of the jobs. A search for DB optimization was taken and some deficiencies 
> were discovered, we can group them in 4 groups:
> * Incorrect PRIMARY key
> * Duplicate PRIMARY KEY
> * Missing indexes (Add indexes to avoid full table scans)
> * Some views query (Change view to improve account retrieval speed)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to