[
https://issues.apache.org/jira/browse/CLOUDSTACK-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267209#comment-15267209
]
ASF GitHub Bot commented on CLOUDSTACK-9265:
--------------------------------------------
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-216319655
Hi @swill no problem, you might be calling me on other PRs, and I might
have not answered you. Sadly, duty is calling these days, few papers were
accepted and now I have to work with all of those bureaucracy and also I have
to get a camera ready version; that I why I haven't had much time to be around
here lately. If it is something important you can send me an email.
I have just re-checked this one.
Although I find the addition of “final” everywhere something that was not
needed; @DaanHoogland knows that I am very picky sometimes ;). What was
promised by the PR description was implemented here, and I am ok with that.
LGTM here too.
> some java classes use commons-httpclient where httpcomponents is intended
> -------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9265
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9265
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Daan Hoogland
> Priority: Trivial
>
> in several classes imports of HttpStatus or -Exception is from the old
> org.apache.commons.httpclient package while the newer org.apache.http should
> be used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)