[
https://issues.apache.org/jira/browse/CLOUDSTACK-8800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270335#comment-15270335
]
ASF GitHub Bot commented on CLOUDSTACK-8800:
--------------------------------------------
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r62006414
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -205,14 +205,21 @@ public UserVmResponse newUserVmResponse(ResponseView
view, String objectName, Us
userVmResponse.setNetworkKbsWrite((long)vmStats.getNetworkWriteKBs());
- if ((userVm.getHypervisorType() != null) &&
(userVm.getHypervisorType().equals(HypervisorType.KVM) ||
userVm.getHypervisorType().equals(HypervisorType.XenServer))) { // support KVM
and XenServer only util 2013.06.25
+ if ((userVm.getHypervisorType() != null) &&
(userVm.getHypervisorType().equals(HypervisorType.KVM) ||
userVm.getHypervisorType().equals(HypervisorType.XenServer) ||
userVm.getHypervisorType().equals(HypervisorType.VMware))) { // support KVM and
XenServer only util 2013.06.25 . supporting Vmware from 2015.09.02
--- End diff --
I removed the HV checks and ran it on a simulator and worked as expected,
returned 0 for the newly added fields in response. Since this is supposed to
work for XS, KVM, VMware anyways, and simulator works as well, guess the check
can be removed.
> Improve the listVirtualMachines API call to include memory utilization
> information for a VM
> -------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8800
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8800
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.5.2
> Reporter: Maneesha
> Assignee: Maneesha
> Fix For: Future
>
>
> Currently the feature of memory utilization is not available via API call
> (listVirtualMachines).
> https://cloudstack.apache.org/api/apidocs-4.5/root_admin/listVirtualMachines.html
>
> The listVirtualMachine get its values from the "user_vm_view" table in the
> database. Currently it shows the CPU utilization of the VM's.
> The only way to find out the memory utilization of VM's running on XenServer,
> is to run the "xentop" command on the pool master of the cluster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
