[
https://issues.apache.org/jira/browse/CLOUDSTACK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273081#comment-15273081
]
ASF GitHub Bot commented on CLOUDSTACK-9348:
--------------------------------------------
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1534#issuecomment-217278185
Well the test runs a lot faster/cleaner now. 👍
```
Running com.cloud.utils.testcase.NioTest
2016-05-05 22:53:54,828 INFO [utils.testcase.NioTest] (main:) Setting up
Benchmark Test
2016-05-05 22:53:54,861 INFO [utils.nio.NioServer] (main:) NioConnection
started and listening on /0:0:0:0:0:0:0:0:41317
2016-05-05 22:53:54,874 INFO [utils.testcase.NioTest]
(MaliciousNioClientHandler-1:) Connecting to 127.0.0.1:41317
2016-05-05 22:53:54,874 INFO [utils.testcase.NioTest]
(MaliciousNioClientHandler-3:) Connecting to 127.0.0.1:41317
2016-05-05 22:53:54,874 INFO [utils.testcase.NioTest]
(MaliciousNioClientHandler-4:) Connecting to 127.0.0.1:41317
2016-05-05 22:53:54,882 DEBUG [utils.testcase.NioTest] (Time-limited test:)
0/4 tests done. Waiting for completion
2016-05-05 22:53:54,875 INFO [utils.testcase.NioTest]
(MaliciousNioClientHandler-2:) Connecting to 127.0.0.1:41317
2016-05-05 22:53:54,885 INFO [utils.nio.NioClient] (NioClientHandler-4:)
Connecting to 127.0.0.1:41317
2016-05-05 22:53:54,884 INFO [utils.nio.NioClient] (NioClientHandler-3:)
Connecting to 127.0.0.1:41317
2016-05-05 22:53:54,878 INFO [utils.nio.NioClient] (NioClientHandler-2:)
Connecting to 127.0.0.1:41317
2016-05-05 22:53:54,877 INFO [utils.nio.NioClient] (NioClientHandler-1:)
Connecting to 127.0.0.1:41317
2016-05-05 22:53:54,899 DEBUG [utils.crypt.EncryptionSecretKeyChecker]
(pool-1-thread-1:) Encryption Type: null
2016-05-05 22:53:54,902 WARN [utils.nio.Link] (pool-1-thread-1:) SSL: Fail
to find the generated keystore. Loading fail-safe one to continue.
2016-05-05 22:53:55,039 WARN [utils.nio.Link] (pool-1-thread-1:) SSL: Fail
to find the generated keystore. Loading fail-safe one to continue.
2016-05-05 22:53:55,045 WARN [utils.nio.Link] (pool-1-thread-1:) SSL: Fail
to find the generated keystore. Loading fail-safe one to continue.
2016-05-05 22:53:55,054 WARN [utils.nio.Link] (pool-1-thread-1:) SSL: Fail
to find the generated keystore. Loading fail-safe one to continue.
2016-05-05 22:53:55,112 WARN [utils.nio.Link] (pool-1-thread-1:) SSL: Fail
to find the generated keystore. Loading fail-safe one to continue.
2016-05-05 22:53:55,119 WARN [utils.nio.Link] (pool-1-thread-1:) SSL: Fail
to find the generated keystore. Loading fail-safe one to continue.
2016-05-05 22:53:55,126 WARN [utils.nio.Link] (pool-1-thread-1:) SSL: Fail
to find the generated keystore. Loading fail-safe one to continue.
2016-05-05 22:53:55,145 WARN [utils.nio.Link] (pool-1-thread-1:) SSL: Fail
to find the generated keystore. Loading fail-safe one to continue.
2016-05-05 22:53:55,886 DEBUG [utils.testcase.NioTest] (Time-limited test:)
0/4 tests done. Waiting for completion
2016-05-05 22:53:56,152 INFO [utils.nio.NioClient] (NioClientHandler-3:)
SSL: Handshake done
2016-05-05 22:53:56,152 INFO [utils.nio.NioClient] (NioClientHandler-3:)
Connected to 127.0.0.1:41317
2016-05-05 22:53:56,198 INFO [utils.testcase.NioTest]
(NioTestClient-2-Handler-1:) Client: Received CONNECT task
2016-05-05 22:53:56,258 INFO [utils.testcase.NioTest]
(NioTestClient-2-Handler-1:) Sending data to server
2016-05-05 22:53:56,236 INFO [utils.nio.NioClient] (NioClientHandler-1:)
SSL: Handshake done
2016-05-05 22:53:56,259 INFO [utils.nio.NioClient] (NioClientHandler-1:)
Connected to 127.0.0.1:41317
2016-05-05 22:53:56,232 INFO [utils.nio.NioClient] (NioClientHandler-4:)
SSL: Handshake done
2016-05-05 22:53:56,260 INFO [utils.nio.NioClient] (NioClientHandler-4:)
Connected to 127.0.0.1:41317
2016-05-05 22:53:56,225 INFO [utils.nio.NioClient] (NioClientHandler-2:)
SSL: Handshake done
2016-05-05 22:53:56,260 INFO [utils.nio.NioClient] (NioClientHandler-2:)
Connected to 127.0.0.1:41317
2016-05-05 22:53:56,260 INFO [utils.testcase.NioTest]
(NioTestClient-0-Handler-1:) Client: Received CONNECT task
2016-05-05 22:53:56,285 INFO [utils.testcase.NioTest]
(NioTestClient-0-Handler-1:) Sending data to server
2016-05-05 22:53:56,285 INFO [utils.testcase.NioTest]
(NioTestClient-3-Handler-1:) Client: Received CONNECT task
2016-05-05 22:53:56,331 INFO [utils.testcase.NioTest]
(NioTestClient-3-Handler-1:) Sending data to server
2016-05-05 22:53:56,284 INFO [utils.testcase.NioTest]
(NioTestClient-1-Handler-1:) Client: Received CONNECT task
2016-05-05 22:53:56,368 INFO [utils.testcase.NioTest]
(NioTestClient-1-Handler-1:) Sending data to server
2016-05-05 22:53:56,286 INFO [utils.testcase.NioTest]
(NioTestServer-Handler-1:) Server: Received CONNECT task
2016-05-05 22:53:56,487 INFO [utils.testcase.NioTest]
(NioTestServer-Handler-1:) Server: Received CONNECT task
2016-05-05 22:53:56,487 INFO [utils.testcase.NioTest]
(NioTestServer-Handler-1:) Server: Received CONNECT task
2016-05-05 22:53:56,487 INFO [utils.testcase.NioTest]
(NioTestServer-Handler-1:) Server: Received CONNECT task
2016-05-05 22:53:56,999 DEBUG [utils.testcase.NioTest] (Time-limited test:)
0/4 tests done. Waiting for completion
2016-05-05 22:53:57,319 INFO [utils.testcase.NioTest]
(NioTestServer-Handler-1:) Server: Received DATA task
2016-05-05 22:53:57,331 INFO [utils.testcase.NioTest]
(NioTestServer-Handler-1:) Verify data received by server done.
2016-05-05 22:53:57,331 INFO [utils.testcase.NioTest]
(NioTestServer-Handler-1:) Server: Received DATA task
2016-05-05 22:53:57,332 INFO [utils.testcase.NioTest]
(NioTestServer-Handler-1:) Verify data received by server done.
2016-05-05 22:53:57,332 INFO [utils.testcase.NioTest]
(NioTestServer-Handler-1:) Server: Received DATA task
2016-05-05 22:53:57,333 INFO [utils.testcase.NioTest]
(NioTestServer-Handler-1:) Verify data received by server done.
2016-05-05 22:53:57,333 INFO [utils.testcase.NioTest]
(NioTestServer-Handler-1:) Server: Received DATA task
2016-05-05 22:53:57,334 INFO [utils.testcase.NioTest]
(NioTestServer-Handler-1:) Verify data received by server done.
2016-05-05 22:53:58,003 DEBUG [utils.testcase.NioTest] (Time-limited test:)
4/4 tests done.
2016-05-05 22:53:58,003 INFO [utils.testcase.NioTest] (main:) Clients
stopped.
2016-05-05 22:53:58,004 INFO [utils.testcase.NioTest] (main:) Server
stopped.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.18 sec -
in com.cloud.utils.testcase.NioTest
```
I have CI running against it now, so I will have results for the full CI
run soon...
> CloudStack Server degrades when a lot of connections on port 8250
> -----------------------------------------------------------------
>
> Key: CLOUDSTACK-9348
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9348
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rohit Yadav
> Assignee: Rohit Yadav
> Fix For: 4.9.0
>
>
> An intermittent issue was found with a large CloudStack deployment, where
> servers could not keep agents connected on port 8250.
> All connections are handled by accept() in NioConnection:
> https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125
> A new connection is handled by accept() which does blocking SSL handshake. A
> good fix would be to make this non-blocking and handle expensive tasks in
> separate threads/pool. This way the main IO loop won't be blocked and can
> continue to serve other agents/clients.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
